add "inboxStyle" property to notification (Android only) #554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The library is missing the possibility to set the InboxStyle to the notification. This PR adds it.
For details about the InboxStyle: https://developer.android.com/reference/android/app/Notification.InboxStyle.html
Usage
PushNotification.localNotification()
andPushNotification.localNotificationSchedule()
now accepts a new optional property that isinboxStyle
. Following an example:Test plan
I added the
inboxStyle
property to the object passed toPushNotification.localNotification()
andPushNotification.localNotificationSchedule()
and the notification gets displayed correctly.If I don't add the
inboxStyle
, the behavior does not change.About the code
I needed to copy-paste the code of
Arguments.java
from react-native repo because, before RN 0.48.0,Arguments
was not able to convert lists from ReadableMap to Bundle. I wanted to make this PR compatible with older versions of RN, so I copied the code into thehelpers
namespace.I also needed to add a
RNUtil
class in order to convert ajson
toWritableMap
and vice versa.